Fixes for pylint 2.17.2 (Fedora 38) #5708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylint 2.17.2 (Fedora 38) seems to complain about this. Signed-off-by: David Gibson <[email protected]>
Several tests in selftests/.data/test_statuses.py log a message after calling sys.exit(), which causes 2.17.2 (Fedora 38) to complain about unreachable code. It looks like these messages are here so we can see what's happening if sys.exit() were ever to *not* behave as we expect, so we don't want to remove then. Instead use a pylint suppression. Signed-off-by: David Gibson <[email protected]>
pylint 2.17.2 (Fedora 38) gives warnings if the exception classes specified in the overgeneral-exceptions option of the config don't give a module. Fully qualify them with 'builtins.' to stop this warning. Signed-off-by: David Gibson <[email protected]>
pylint 2.17.2 (Fedora 38) complains about places that raise an overly broad exception, such as bare 'Exception' rather than a derived class. Change most places that do that to raise an appropriate derived class. One remaining place appears to be deliberately raising the generic exception, so use a pylint suppression there instead. Signed-off-by: David Gibson <[email protected]>
|
Ah, dang it. Thought my pull was up to date, but it wasn't, so I failed to spot these were already fixed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkon the avocado sources fails on Fedora 38 due to pylint errors. This seems to be because of new warnings introduced with a newer pylint. Fix them.